Skip to content

Add compact_chunk function#9957

Merged
antekresic merged 1 commit into
mainfrom
antekresic/compaction_poc
Jun 23, 2026
Merged

Add compact_chunk function#9957
antekresic merged 1 commit into
mainfrom
antekresic/compaction_poc

Conversation

@antekresic

Copy link
Copy Markdown
Member

This new function will compact the chunk by looking for overlapping batches and combining them together in order to produce globally ordered chunks. This is change is a first step towards supporting direct compress in production workloads.

@antekresic antekresic self-assigned this Jun 3, 2026
@antekresic antekresic added the enhancement An enhancement to an existing feature for functionality label Jun 3, 2026
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.46939% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tsl/src/compression/recompress.c 93.30% 3 Missing and 13 partials ⚠️

📢 Thoughts on this report? Let us know!

@antekresic antekresic force-pushed the antekresic/compaction_poc branch from ff03edc to 2dce6bf Compare June 3, 2026 11:20
@antekresic antekresic marked this pull request as ready for review June 3, 2026 13:42
@github-actions github-actions Bot requested review from kpan2034 and svenklemm June 3, 2026 13:42
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

@svenklemm, @kpan2034: please review this pull request.

Powered by pull-review

Comment thread tsl/src/compression/recompress.c
Comment thread tsl/src/compression/recompress.c
Comment thread tsl/src/compression/recompress.c Outdated
@antekresic antekresic force-pushed the antekresic/compaction_poc branch from 2dce6bf to 3a9fb1a Compare June 16, 2026 10:36

@svenklemm svenklemm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antekresic antekresic force-pushed the antekresic/compaction_poc branch from 3a9fb1a to 1d729b9 Compare June 19, 2026 08:08
Comment thread tsl/src/compression/COMPACT_CHUNK.md
Comment thread tsl/src/compression/recompress.c

@akuzm akuzm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much more straighforward with the new sparse index type.

@antekresic antekresic force-pushed the antekresic/compaction_poc branch 2 times, most recently from d2e7369 to 71fd91f Compare June 23, 2026 09:58
@antekresic antekresic enabled auto-merge (rebase) June 23, 2026 09:58
@antekresic antekresic force-pushed the antekresic/compaction_poc branch from 71fd91f to d969a2b Compare June 23, 2026 10:00
This new function will compact the chunk by looking for overlapping
batches and combining them together in order to produce globally
ordered chunks. This change is a first step towards supporting
direct compress in production workloads.
@antekresic antekresic force-pushed the antekresic/compaction_poc branch from d969a2b to e21fd8b Compare June 23, 2026 10:08
@antekresic antekresic merged commit 0dfe7fa into main Jun 23, 2026
55 of 57 checks passed
@antekresic antekresic deleted the antekresic/compaction_poc branch June 23, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement to an existing feature for functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants